Skip to content

url: handle unparsable serialized URLs in setters - #64651

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:url-handle-unparsable-href-updates
Aug 5, 2026
Merged

url: handle unparsable serialized URLs in setters#64651
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:url-handle-unparsable-href-updates

Conversation

@mcollina

@mcollina mcollina commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

URL updates reparse the stored serialized URL. Return failure when that parse does not succeed so property setters leave the URL unchanged.

Add coverage for URL values that are accepted initially but whose serialized form cannot be parsed again.

@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jul 21, 2026
@mcollina
mcollina force-pushed the url-handle-unparsable-href-updates branch from 0fee8e8 to 985563f Compare July 21, 2026 13:19
@codecov

codecov Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.29%. Comparing base (276fe2b) to head (7f6c2a7).
⚠️ Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
src/node_url.cc 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #64651   +/-   ##
=======================================
  Coverage   90.28%   90.29%           
=======================================
  Files         760      760           
  Lines      247076   247105   +29     
  Branches    46594    46593    -1     
=======================================
+ Hits       223081   223113   +32     
- Misses      15458    15463    +5     
+ Partials     8537     8529    -8
Files with missing lines Coverage Δ
src/node_url.cc 77.71% <0.00%> (-0.49%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell
jasnell reviewed Jul 21, 2026
View reviewed changes
Comment thread test/parallel/test-whatwg-url-custom-setters.js
@wooffie wooffie mentioned this pull request Jul 23, 2026
Closed
@mcollina
mcollina force-pushed the url-handle-unparsable-href-updates branch from 985563f to 4024725 Compare July 25, 2026 08:31
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75317/

@mcollina
mcollina force-pushed the url-handle-unparsable-href-updates branch from 4024725 to 48e0076 Compare August 1, 2026 09:37
@mcollina
url: handle unparsable serialized URLs in setters
7f6c2a7 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina force-pushed the url-handle-unparsable-href-updates branch from 48e0076 to 7f6c2a7 Compare August 1, 2026 21:49
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75430/

@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75456/

@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75460/

@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75507/

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Aug 5, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot merged commit b33cc0e into nodejs:main Aug 5, 2026
78 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Landed in b33cc0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina @nodejs-github-bot @panva @jasnell @anonrig